Skip to content

Figure.magnetic_rose: Let declination_label support string with whitespaces#4422

Merged
seisman merged 3 commits intomainfrom
magnetic_rose/label
Feb 25, 2026
Merged

Figure.magnetic_rose: Let declination_label support string with whitespaces#4422
seisman merged 3 commits intomainfrom
magnetic_rose/label

Conversation

@seisman
Copy link
Member

@seisman seisman commented Feb 20, 2026

GMT CLI also doesn't support declination labels with whitespaces. This PR patches it by replacing whitespaces with octal codes \040.

GMT CLI version:

gmt basemap -R0/10/0/10 -JM10c -Tmx0/0+w5c+d30/"123 N" -pdf map

Patches #4051

@seisman seisman added this to the 0.19.0 milestone Feb 20, 2026
@seisman seisman added bug Something isn't working skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Feb 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_magnetic_rose_complete.png

Image diff(s)

Details

Added images

Modified images

Path Old New
test_magnetic_rose_complete.png

Report last updated at commit 304713c

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Feb 24, 2026
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 25, 2026
@seisman seisman merged commit 867b4bb into main Feb 25, 2026
25 of 33 checks passed
@seisman seisman deleted the magnetic_rose/label branch February 25, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant